BUG: TypeError when doing equality comparison with Extension Dtype #44618

ata-turhan · 2021-11-25T16:01:25Z

BUG: Compare type int64 with Int64 fails #43038 closes #xxxx
1 tests added / passed
Ensure all linting tests pass, see here for how to run them
whatsnew entry

)

…pes (#44594)

…rser (#44599) * BUG: Providing fix for GH#44366 * BUG: fix pre-commit run * BUG: adding other API changes for change of default argument * Rewriting if statement and adding test * BUG: changing pd.Series to Series to validate pre-commit hook * Removing the second whatsnew statement only to keep the bug fix one * BUG: simplifying the test with parser and parse_dates False #44366 * BUG: fixing pre-commit #44366

pep8speaks · 2021-11-25T21:15:38Z

Hello @fotino21! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file pandas/tests/dtypes/test_common.py:

Line 400:89: E501 line too long (100 > 88 characters)

Comment last updated at 2021-12-05 10:54:23 UTC

#44534)

jreback · 2021-11-25T23:28:32Z

pandas/tests/dtypes/test_common.py

@@ -391,6 +392,41 @@ def test_is_unsigned_integer_dtype(dtype):
 def test_is_not_unsigned_integer_dtype(dtype):
    assert not com.is_unsigned_integer_dtype(dtype)

+def test_all_type_comparison():
+    assert pd.api.types.pandas_dtype("int_") == "int_"


pls paramterize instead of writing out like this

I made the change you requested @jreback

…0984)

…ests-for-dtype-comparisons added fix � �:Qa :qw

…no21/pandas into tests-for-dtype-comparisons

jreback · 2021-12-06T14:28:05Z

something when wrong

ata-turhan · 2021-12-06T15:57:12Z

@jreback I didn't understand

jreback · 2021-12-06T16:56:21Z

@fotino21 you are updating a huge amount of code. make sure you are merging in master

ata-turhan · 2021-12-06T17:49:15Z

@fotino21 you are updating a huge amount of code. make sure you are merging in master

@jreback My changes are small and they are only in test_common file. What do i need to do for other commits by other people. And sorry for the inconvenience. This is my first contribution to a huge code base.

ata-turhan · 2021-12-07T20:49:30Z

@jreback @phofl Do I need to do anything else before merge?

jreback · 2021-12-07T23:28:20Z

@jreback @phofl Do I need to do anything else before merge?

yes you need to rebase against upstream master

ata-turhan · 2021-12-08T00:08:40Z

@jreback @phofl Do I need to do anything else before merge?

yes you need to rebase against upstream master

@jreback I made it following this link: https://timonweb.com/misc/how-to-update-a-forked-repo-from-an-upstream-with-git-rebase-or-merge/

ata-turhan · 2021-12-09T09:04:21Z

@jreback @phofl Do I need to do anything else before merge?

jreback · 2021-12-09T12:34:15Z

@fotino21 this has included lots of other changes u need to merge upstream/master

ata-turhan · 2021-12-09T12:41:23Z

@fotino21 this has included lots of other changes u need to merge upstream/master

How can i do that? I already based my master branch to upstream/master

MarcoGorelli · 2021-12-10T12:36:04Z

can you try

git fetch upstream
git rebase -i upstream/master
git push origin HEAD -f

?
In the second step, you should get an interactive window, and you can choose which commits to keep / edit

ata-turhan · 2021-12-10T12:48:25Z

@MarcoGorelli

In the second step, I only see this message:

noop

Rebase `bc17343`..`bc17343` onto `bc17343` (1 command)

Commands:

p, pick = use commit

r, reword = use commit, but edit the commit message

e, edit = use commit, but stop for amending

s, squash = use commit, but meld into previous commit

f, fixup [-C | -c] = like "squash" but keep only the previous

commit's log message, unless -C is used, in which case

keep only this commit's message; -c is same as -C but

opens the editor

x, exec = run command (the rest of the line) using shell

b, break = stop here (continue rebase later with 'git rebase --continue')

d, drop = remove commit

l, label = label current HEAD with a name

t, reset = reset HEAD to a label

m, merge [-C | -c ] [# ]

. create a merge commit using the original merge commit's

. message (or the oneline, if no original merge commit was

. specified); use -c to reword the commit message

These lines can be re-ordered; they are executed from top to bottom.

If you remove a line here THAT COMMIT WILL BE LOST.

However, if you remove everything, the rebase will be aborted.

MarcoGorelli · 2021-12-10T13:20:15Z

🤔 to be honest I don't know, I can't even tell how you opened this PR as it doesn't appear to have come from a branch

the other PR (#44840) does come from a branch, so maybe it's OK to continue there, then I can check it out locally if necessary

jreback · 2021-12-10T18:49:47Z

closing in favor of #44840

@fotino21 ideallly we only have a single, original PR as it makes more work for maintaining.

ata-turhan and others added 17 commits November 25, 2021 18:58

test added for issue #43038

5df8f47

PERF: Improve performance in read_csv with numeric index col (#44610)

7f43278

BUG: Series.reset_index not ignoring name with inplace and drop (#44578)

dfea876

[DOC] Transferring data from the 6th column to the first. #44379 (#44427

0e9f929

)

PERF: improve find_common_type perf for special case of all-equal dty…

d621e8e

…pes (#44594)

DOC: update shared_docs to clarify groupby with lists (#44569)

7ca5a6b

BUG: concat_compat with 2D PeriodArray (#44598)

4f91875

REF: remove always-True DataFrame._iset_item kwarg (#44587)

2b53ea8

BUG: Series.where with IntervalDtype when no-op (#44585)

93297e0

REF: use base class for BooleanArray any/all (#44549)

00f4417

Fix 'rtol' and 'atol' for numeric extension types (#44488)

56b3e59

Pass through Engine kwargs in ExcelWriter (#43445)

fd95026

BUG: DataFrame.shift with axis=1 and mismatched fill_value (#44564)

7a9975f

DOC: GL01 Numpydoc validation (#44567)

63945c0

BUG: join MultiIndex with overlapping IntervalIndex level (#44096) (#…

f0d4d8d

…44588)

BUG: Series.view from int64 to datetimelike (#44581)

d74cb77

ata-turhan closed this Nov 25, 2021

ata-turhan reopened this Nov 25, 2021

ata-turhan and others added 3 commits November 26, 2021 00:16

Update test_common.py

c250432

ASV: reduce overall run time for GroupByMethods benchmarks (#44604)

c8a0804

DOC: 'MS' offset alias does not work as described with pd.date_range() (

2f203d1

#44534)

jreback changed the title ~~test added for issue #43038~~ BUG: conpare int64 and Int64 Nov 25, 2021

jreback requested changes Nov 25, 2021

View reviewed changes

jorisvandenbossche and others added 4 commits November 26, 2021 07:28

TST: make tests involving use_numexpr more robust (#44601)

5ee8cf1

ENH: option to change the number in _dir_additions_for_owner (#44335)

068b599

TYP: Signature of "reindex" incompatible with supertype "NDFrame" (#4…

a164326

…0984)

BUG: read_fwf not handling skiprows correctly with iterator (#44621)

d6723fd

jreback changed the title ~~BUG: conpare int64 and Int64~~ BUG: compare int64 and Int64 Nov 26, 2021

jbrockmendel and others added 11 commits December 5, 2021 15:12

CLN/TST: skips -> xfails (#44744)

0635a25

Merge branch 'tests-ons' of https://github.com/fotino21/pandas into t…

b435403

…ests-for-dtype-comparisons added fix � �:Qa :qw

fixtured

a86d590

44414 data frame attributes not propagating with astype (#44680)

1fe373f

Updated code_checks.sh with PR06 (#43511)

2d0fa31

DOC: Uniform block directive syntax. (#44757)

9c74428

fix PR06 failing CI (#44773)

b7ac9be

ENH: IntervalArray.min/max (#44746)

e6f0d1d

CLN: FIXMEs (#44771)

097322f

Merge branch 'tests-for-dtype-comparisons' of https://github.com/foti…

9bb7211

…no21/pandas into tests-for-dtype-comparisons

fixtures

bbced30

ata-turhan requested a review from jreback December 6, 2021 16:38

ata-turhan requested a review from phofl December 8, 2021 12:24

This was referenced Dec 10, 2021

tests with fixture for dtypes added #44836

Closed

Tests added for dtype comparison with fixture #44840

Merged

jreback closed this Dec 10, 2021

Uh oh!

BUG: TypeError when doing equality comparison with Extension Dtype #44618

BUG: TypeError when doing equality comparison with Extension Dtype #44618

Uh oh!

Conversation

ata-turhan commented Nov 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pep8speaks commented Nov 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment last updated at 2021-12-05 10:54:23 UTC

Uh oh!

jreback Nov 25, 2021

Choose a reason for hiding this comment

Uh oh!

ata-turhan Nov 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jreback commented Dec 6, 2021

Uh oh!

ata-turhan commented Dec 6, 2021

Uh oh!

jreback commented Dec 6, 2021

Uh oh!

ata-turhan commented Dec 6, 2021

Uh oh!

ata-turhan commented Dec 7, 2021

Uh oh!

jreback commented Dec 7, 2021

Uh oh!

ata-turhan commented Dec 8, 2021

Uh oh!

ata-turhan commented Dec 9, 2021

Uh oh!

jreback commented Dec 9, 2021

Uh oh!

ata-turhan commented Dec 9, 2021

Uh oh!

MarcoGorelli commented Dec 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ata-turhan commented Dec 10, 2021

Rebase bc17343..bc17343 onto bc17343 (1 command)

Commands:

p, pick = use commit

r, reword = use commit, but edit the commit message

e, edit = use commit, but stop for amending

s, squash = use commit, but meld into previous commit

f, fixup [-C | -c] = like "squash" but keep only the previous

commit's log message, unless -C is used, in which case

keep only this commit's message; -c is same as -C but

opens the editor

x, exec = run command (the rest of the line) using shell

b, break = stop here (continue rebase later with 'git rebase --continue')

d, drop = remove commit

l, label = label current HEAD with a name

t, reset = reset HEAD to a label

m, merge [-C | -c ] [# ]

. create a merge commit using the original merge commit's

. message (or the oneline, if no original merge commit was

. specified); use -c to reword the commit message

These lines can be re-ordered; they are executed from top to bottom.

If you remove a line here THAT COMMIT WILL BE LOST.

However, if you remove everything, the rebase will be aborted.

Uh oh!

MarcoGorelli commented Dec 10, 2021

Uh oh!

jreback commented Dec 10, 2021

Uh oh!

Uh oh!

ata-turhan commented Nov 25, 2021 •

edited

Loading

pep8speaks commented Nov 25, 2021 •

edited

Loading

ata-turhan Nov 28, 2021 •

edited

Loading

MarcoGorelli commented Dec 10, 2021 •

edited

Loading

Rebase `bc17343`..`bc17343` onto `bc17343` (1 command)